Move listeners module to shared library for client server separation #59883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoghrajesh
requested review from
ephraimbuddy,
rawwar,
sunank200 and
uranusjr
amoghrajesh
commented
Dec 29, 2025
amoghrajesh
commented
Dec 30, 2025
potiuk
reviewed
Jan 6, 2026
potiuk
reviewed
Jan 6, 2026
amoghrajesh
force-pushed
the
move-listeners-to-shared
branch
2 times, most recently
from
93d3cf8 to
11403fb
Compare
amoghrajesh
commented
Jan 7, 2026
amoghrajesh
force-pushed
the
move-listeners-to-shared
branch
from
1d8a0b8 to
c463664
Compare
amoghrajesh
changed the title
potiuk
reviewed
Jan 7, 2026
potiuk
reviewed
Jan 7, 2026
potiuk
approved these changes
Jan 7, 2026
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
Good - I tnink dagnode leaked from another branch - but other than that - it's exactly how I imagined it :)
Member
|
Also - there are two remaining questions about tests -> I am not sure why we have task.sdk in airflow-core unit tests ? |
Contributor
Author
|
@kaxil there's a request changes from you over here, could you take a look again? Or remove the request change if your veto was handled? |
kaxil
approved these changes
Jan 8, 2026
uranusjr
reviewed
Jan 8, 2026
amoghrajesh
force-pushed
the
move-listeners-to-shared
branch
from
8a02228 to
4a63f94
Compare
1 task
dabla
pushed a commit
to dabla/airflow
that referenced
this pull request
Jan 8, 2026
…pache#59883) Extract the listeners infrastructure to `shared/listeners/` library to eliminate cross dependencies between airflow-core and task-sdk. - ListenerManager and hookimpl marker now in shared library - Hook specs split by callers: - shared: lifecycle, taskinstance (called from both sdk and core) - core: dagrun, asset, importerrors (called only from core) - sdk registers only specs it actually uses (lifecycle, taskinstance) - core registers all specs for full listener support
chirodip98
pushed a commit
to chirodip98/airflow-contrib
that referenced
this pull request
Jan 9, 2026
…pache#59883) Extract the listeners infrastructure to `shared/listeners/` library to eliminate cross dependencies between airflow-core and task-sdk. - ListenerManager and hookimpl marker now in shared library - Hook specs split by callers: - shared: lifecycle, taskinstance (called from both sdk and core) - core: dagrun, asset, importerrors (called only from core) - sdk registers only specs it actually uses (lifecycle, taskinstance) - core registers all specs for full listener support
stegololz
pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
…pache#59883) Extract the listeners infrastructure to `shared/listeners/` library to eliminate cross dependencies between airflow-core and task-sdk. - ListenerManager and hookimpl marker now in shared library - Hook specs split by callers: - shared: lifecycle, taskinstance (called from both sdk and core) - core: dagrun, asset, importerrors (called only from core) - sdk registers only specs it actually uses (lifecycle, taskinstance) - core registers all specs for full listener support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #54701
Why?
Simply stating, for client server separation.
The
airflow.listenersmodule was used between airflow-core and task-sdk. By extracting the shared components to a shared library, I am intending to solve the problem of cross dependency between airflow-core and task-sdk.What's done?
Created
shared/listeners/library containing:ListenerManagerclass (manages plugin registration and hook dispatching)hookimplmarker for implementing listenersHook specs are now houses by where they're called from:
Both airflow-core and task-sdk now:
_shared/listeners/)SDK now only registers specs it actually uses:
lifecycle(on_starting, before_stopping)taskinstance(on_task_instance_*)Open Questions and Direction to proceed
Type hints in hook specs
The specs use TYPE_CHECKING imports to avoid runtime dependencies:
taskinstancespec uses union typeRuntimeTaskInstance | TaskInstancesince it's called from both SDK workers and Core API serverTODO
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.